which is better for volume control

It all depends. Passive tone controls produce some noise, so better before the volume control where the signal is stronger. Active tone controls can overload, so may be better after the volume control. It is all a matter of balancing one thing off against another. It may also depend on application - guitar/studio or hi-fi?